----- Original Message ----- 
From: "Peter Wemm" <[EMAIL PROTECTED]>
To: "David Xu" <[EMAIL PROTECTED]>
Cc: <[EMAIL PROTECTED]>
Sent: Thursday, November 01, 2001 9:43 AM
Subject: Re: pmap_collect() and PG_UNMANAGED 


> "David Xu" wrote:
> > This is a multi-part message in MIME format.
> > 
> > ------=_NextPart_000_000C_01C162B1.0ECE7770
> > Content-Type: text/plain;
> > charset="gb2312"
> > Content-Transfer-Encoding: quoted-printable
> > 
> > Hi,
> > 
> >   is there any reason why pmap_collect() in /sys/i386/i386/pmap.c does =
> > not
> >   check PG_UNMANAGED flag? unmanaged page does not have pv_entry =
> > associated,
> >   so call pmap_remove_all() has side effect, PG_MAPPED and PG_WRITEABLE =
> > are=20
> >   roughly cleared.
> > 
> > --
> > David Xu
> 
> Did you have something like this in mind?
> 
> @@ -1729,7 +1729,7 @@
>         for(i = 0; i < vm_page_array_size; i++) {
>                 m = &vm_page_array[i];
>                 if (m->wire_count || m->hold_count || m->busy ||
> -                   (m->flags & PG_BUSY))
> +                   (m->flags & (PG_BUSY | PG_UNMANAGED)))
>                         continue;
>                 pmap_remove_all(m);
>         }
> 

Yes, I have changed and tested it yesterday, I have pushed a memory hog program into 
system, run it about half an hour, almost every program was swapped out, still without
cause any problem, it seems it is safe to add this flag.

> BTW; please stop posting MIME/HTML onto mailing lists.
> 
Sorry, my MS Outlook express sucks, I will replace it with better one!

> Cheers,
> -Peter
> --
> Peter Wemm - [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]
> "All of this is for nothing if we don't go to the stars" - JMS/B5

--
David Xu



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message

Reply via email to