In message: <[EMAIL PROTECTED]>
            "David O'Brien" <[EMAIL PROTECTED]> writes:
: On Wed, Mar 06, 2002 at 02:08:07AM +0200, Giorgos Keramidas wrote:
: > On 2002-03-05 15:58, David O'Brien wrote:
: > > On Tue, Mar 05, 2002 at 10:13:50PM +0200, Giorgos Keramidas wrote:
: > > > > -Don't use '!' for tests unless it's a boolean, e.g. use
: > > > > +For tests, always compare the value to the appropriate 0 instead of
: > > > > +checking it directly, unless the value is a boolean.
: > ...
: > > 
: > > Please show examples from /sys that back up this change.  To state this
: > > explicitly, I think a significant number of /sys files should be
: > > following it.
: > 
: > Actually I was asking for comments, but anyways.
: 
: I was giving one. :-)
: style(9) documents the practices of /sys.  Thus we should not arbitaryly
: add rules w/o them being backed up in code.

I believe that sys/pccard, sys/dev/{pccard,pcic,pccbb,cardbus} tends
to follow this rule.  If you are looking for examples.

Warner

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message

Reply via email to