Le 2002-12-02, Peter Pentchev �crivait :

> > Attached are two patches: a trivial one which just fixes up two problems
> > in diskpart's argument parsing, and a more complex one, which does it
> > "the right way" IMHO, using getopt(3).

The getopt-based version sounds better to me.

> +                     case 'd':
> +                             dflag++;
> +                             if (pflag)
> +                                     usage();
> +                             break;
> +                             
> +                     case 'p':
> +                             if (dflag)
> +                                     usage();
> +                             pflag++;
> +                             break;

I'd remove both tests and replace them with a single
  if (pflag && dflag) usage()
after all arguments have been processed.

Thomas.

-- 
    [EMAIL PROTECTED]

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message

Reply via email to