On Fri, Oct 07, 2011 at 04:25:56PM -0700, David Christensen wrote:
> > > That's a typo then, 5709 and 5716 share the same ASIC ID.
> > >
> >
> > Thanks for confirmation.
> > Could you review the attached patch?
>
> Looks good. ASIC ID matches my Dell R210 system:
>
> bce0: <Broadcom NetXtreme II BCM5716 1000Base-T (C0)> mem
> 0xda000000-0xdbffffff irq 16 at device 0.0 on pci2
> miibus0: <MII bus> on bce0
> bce0: Ethernet address: b8:ac:6f:87:95:f1
> bce0: ASIC (0x57092008); Rev (C0); Bus (PCIe x4, 2.5Gbps); B/C (5.2.2); Bufs
> (RX:2;TX:2;PG:8); Flags (SPLT|MSI|MFW); MFW (NCSI 2.0.8)
>
Thanks for testing.
Committed with r226123.
I also noticed that bce(4) may support BCM5716S because brgphy(4)
already supports BCM5709S. Can you test attached patch on BCM5716S?
> Dave
>
>
Index: sys/dev/bce/if_bce.c
===================================================================
--- sys/dev/bce/if_bce.c (revision 226123)
+++ sys/dev/bce/if_bce.c (working copy)
@@ -154,6 +154,10 @@
{ BRCM_VENDORID, BRCM_DEVICEID_BCM5716, PCI_ANY_ID, PCI_ANY_ID,
"Broadcom NetXtreme II BCM5716 1000Base-T" },
+ /* BCM5716S controllers and OEM boards. */
+ { BRCM_VENDORID, BRCM_DEVICEID_BCM5716S, PCI_ANY_ID, PCI_ANY_ID,
+ "Broadcom NetXtreme II BCM5716S 1000Base-SX" },
+
{ 0, 0, 0, 0, NULL }
};
Index: sys/dev/bce/if_bcereg.h
===================================================================
--- sys/dev/bce/if_bcereg.h (revision 226123)
+++ sys/dev/bce/if_bcereg.h (working copy)
@@ -565,6 +565,7 @@
#define BRCM_DEVICEID_BCM5709 0x1639
#define BRCM_DEVICEID_BCM5709S 0x163A
#define BRCM_DEVICEID_BCM5716 0x163B
+#define BRCM_DEVICEID_BCM5716S 0x163C
#define HP_VENDORID 0x103C
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[email protected]"
