On 17/10/11 14:13, Adrian Chadd wrote: > I've committed this to -HEAD in r226465. > I'll MFC this to -9 and -8 in the next 3 or so days, re@ approval pending.
Argh... there were a couple of issues someone pointed out to me off-list that you may not have seen: On 17/10/11 01:16, Gang 'Henry' Hu wrote: > There are some minor problems: > > + error = rum_do_request(sc, &req, buf + offset); > > At this line, you should cast buf to (char*), since buf is (void*) > which cannot be used in calculation... > > And you should also return 0 at the end of the function, else there > would be no return value.... I was going to get back to you with a slightly revised freebsd patch to fix those before you committed. Otherwise, Henry said it has fixed the problem for him (in 8.2-STABLE). Regards, -- Steven Chamberlain ste...@pyro.eu.org _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
