On 04.02.2012 21:05, Hiroki Sato wrote:
"Alexander V. Chernikov"<[email protected]>  wrote
   in<[email protected]>:

me>  On 04.02.2012 18:35, Hiroki Sato wrote:
me>  >  Hello,
me>  >
me>  >    Can anyone review/test the attached patch to add "-fib number" option
me>  >    to route(8)?  This should simplify static route configuration across
me>  >    multiple FIBs in rc.conf.  Just adding an -fib option like the
me>  >    following will do the trick without changing rc.d/routing:
me>  >
me>  >     static_routes="foo bar"
me>  >     route_foo="10.1.1.1/24 192.168.2.1 -fib 2"
me>  >     route_bar="10.1.1.1/24 192.168.2.1 -fib 3"
me>  >
me>  >    The -fib option is supported in all subcommands but monitor.
me>  Why should we leave `monitor` as is?
me>
me>  And, even if we really need to do so why "route monitor" silently
me>  accepts and ignores -fib X key?

  No specific reason.  The monitor originally supports no flag to
  filter rt messages and silently ignores any flag.
`setfib 5 route monitor` listening to fib 5 vs
`route monitor -fib 5` listening to fib 0 is obviously not expected behavior :)

  Is this a suggestion that it should support -fib or just from your
There is no reason to leave it inconsistent with other route subcommands.
Route monitor is useful in various debugging related to dynamic routing software (and it should be fib-aware).
  curiosity?  I do not think we really need to leave it.  The attached
  patch is enough to support it, too.
Thanks.

Btw, I've tested patch from previous email on my 8-S box, it works correctly.

-- Hiroki

_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[email protected]"

Reply via email to