The following reply was made to PR kern/110284; it has been noted by GNATS.
From: "Devon H. O'Dell" <[email protected]> To: [email protected], [email protected], [email protected] Cc: Subject: Re: kern/110284: [if_ethersubr] Invalid Assumption in SIOCSIFADDR in ether_ioctl() Date: Wed, 16 May 2012 22:37:36 -0400 2012/5/16 Devon H. O'Dell <[email protected]>: > Hi Gavin, freebsd-net, > > --- if_ethersubr.c =A0 =A0 =A02011-09-22 20:51:37.000000000 -0400 > +++ /home/dho/if_ethersubr.c =A0 =A02012-05-16 22:27:17.000000000 -0400 > @@ -1146,7 +1146,9 @@ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0switch (ifa->ifa_addr->sa_family) { > =A0#ifdef INET > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case AF_INET: > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ifp->if_init(ifp->if_softc)= ; =A0 =A0/* before arpwhohas */ > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (ifp->if_flags & IFF_RUN= NING =3D=3D 0) { That's probably ((ifp->if_flags & IFF_RUNNING) =3D=3D 0). Also, I'm not on freebsd-net or cc'ed on the PR afaik, so please cc me explicitly on followups if more information is needed. --dho > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 ifp->if_ini= t(ifp->if_softc); =A0 =A0/* > before arpwhohas */ > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 } > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0arp_ifinit(ifp, ifa); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0break; > =A0#endif _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "[email protected]"
