On 10.03.2013 03:22, Rick Macklem wrote:
Garett Wollman wrote:
Also, it occurs to me that this strategy is subject to livelock. To
put backpressure on the clients, it is far better to get them to stop
sending (by advertising a small receive window) than to accept their
traffic but queue it for a long time. By the time the NFS code gets
an RPC, the system has already invested so much into it that it should
be processed as quickly as possible, and this strategy essentially
guarantees[1] that, once those 2 MB socket buffers start to fill up,
they
will stay filled, sending latency through the roof. If nfsd didn't
override the usual socket-buffer sizing mechanisms, then sysadmins
could limit the buffers to ensure a stable response time.

The bandwidth-delay product in our network is somewhere between 12.5
kB and 125 kB, depending on how the client is connected and what sort
of latency they experience. The usual theory would suggest that
socket buffers should be no more than twice that -- i.e., about 256
kB.

Well, the code that uses sb_max_adj wasn't written by me (I just cloned
it for the new server). In the author's defence, I believe SB_MAX was 256K when
it was written. It was 256K in 2011. I think sb_max_adj was used because
soreserve() fails for a larger value and the code doesn't check for such a 
failure.
(Yea, it should be fixed so that it checks for a failure return from 
soreserve().
  I did so for the client some time ago.;-)

We have TCP sockbuf size autotuning for some time now.  So explicitly
setting the size shouldn't be necessary anymore.

Just grep for sb_max_adj. You'll see it sets a variable called "siz".
Make "siz" whatever you want (256K sounds like a good guess). Just make
sure it isn't > sb_max_adj.
>
The I/O sizes are limited to MAXBSIZE, which is currently 64Kb, although
I'd like to increase that to 128Kb someday soon. (As you note below, the
largest RPC is slightly bigger than that.)

Btw, net.inet.tcp.{send/recv}buf_max are both 2Mbytes, just like sb_max,
so those don't seem useful in this case?

These are just the limits for auto-tuning.

I'm no TCP guy, so suggestions w.r.t. how big soreserve() should be set
are welcome.

I'd have to look more at the NFS code to see what exactly is going on
and what the most likely settings are going to be.  Won't promise any
ETA though.

--
Andre

_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "[email protected]"

Reply via email to