avg added a subscriber: avg. avg added a comment. This has already been committed, so I've missed the train, but I still would like to comment. And I hope that my comment won't be just a rant. So, I don't like this change for several reasons.
For one, given that nv(9) is a new thing while libnvpair already existed it would have been wise to select non-conflicting names for the new interfaces. And I think that it's still not too late to do that. Then, it seems that this change has solved a theoretical problem as I don't think that currently there is any executable that links to both libraries.Perhaps I am wrong. Also, libnvpair.so was treated like a "private" library: its ABI was wildly changed but its version hasn't been bumped. Finally, from ABI point of view libnvpair now appears very inconsistent: many of its interfaces are prefixed with "illumos_" while quite a few don't have that prefix. Now, why am I interested in libnvpair? At work we have a Python module that interfaces libzfs_core and by necessity libnvpair through CFFI. The module used to work perfectly well across FreeBSD, illumos and Linux because the library interfaces on ABI level are the same (from CFFI's point of view) across platforms. After this change FreeBSD is an odd platform. I have to add a workaround to keep the module working. And even the workaround is not trivial because of the mix of prefixed and non-prefixed names. Hope you sympathize. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1881 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rstone, jfv, will Cc: avg, will, emaste, pjd, freebsd-net _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "[email protected]"
