smh added a subscriber: smh. smh added a comment.
Some general style nits and a question re-loss of the mtu set error. INLINE COMMENTS sys/net/if_lagg.c:706 style(9) bool use of pointer type. sys/net/if_lagg.c:731 style(9) four space additional indent only should be used, more below. sys/net/if_lagg.c:769 Looks like this attempts to change more that would have been done above before the error, is that intended? sys/net/if_lagg.c:783 Looks like the error gets lost, although printed, is there no way we can avoid this? sys/net/if_lagg.c:812 style(9) bracing around return. sys/net/if_lagg.c:818 style(9) init of vars in declaration should be avoided. Moving to down to where its first needed can avoid setting it at all. sys/net/if_lagg.c:837 style(9) bool use of pointer type. sys/net/if_lagg.c:843 style(9) bool use of pointer type. sys/net/if_lagg.c:852 consider: "it might have been updated." sys/net/if_lagg.c:861 style(9) bool use of pointer type. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1986 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rpokala, rstone, rpokala-panasas.com Cc: smh, imp, melifaro, hrs, sbruno, lakshmi.n_msystechnologies.com, emaste, ae, freebsd-net-list _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "[email protected]"
