oleg added a comment.

  Please correct me if i'm wrong but there is ref leakage. In particular:
  
  "If the callout was restarted, the pending bit will be back on and"
  agree.
  
  "we just want to bail"
  no, i would say we should do LLE_REMREF(lle) first, then unlock/return
  because this one is wrong:
  
  "since the callout_reset would return 1 and our reference would have been 
remove by nd6_llinfo_settimer_locked above since canceled would have been 1."
  
  If we got callout_pending() !=0 in callout function it does mean 
callout_reset failed to stop us and callout_reset return value would be 0.
        ‚Äč

REVISION DETAIL
  https://reviews.freebsd.org/D1777

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: rrs, kib, jhb, imp, lstewart, gnn, sbruno, bz, adrian, rwatson
Cc: oleg, ae, bz, freebsd-net-list, emaste, hiren, julian, hselasky
_______________________________________________
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Reply via email to