https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238796
--- Comment #30 from WHR <[email protected]> --- (In reply to Cy Schubert from comment #29) I think this because your patch (attachment 205851) only fixed comparing indexes in 'fr_ifnames', but not indexes in 'fr_tifs' and 'fr_dif'. The order of strings in 'fr_names' doesn't necessary be identical between 2 rule objects that representing same rule; for example the argument for keyward 'on' and 'reply-to' both stored in 'fr_names', but the offsets may differ between 2 objects. The correct comparison should at first check the index numbers in 'fr_tifs' and 'fr_dif', then compare the actual strings referenced by the indexes, in each rule objects, not the indexes itself. And in you last patch, function ipf_ifnames_cmp: > if ((!fr1->fr_ifnames[i] && !fr2->fr_ifnames[i]) || Testing for 0 is incorrect; shouldn't the invalid index be -1? > rc = 1; Why not simply 'return 1;' when a difference is already found? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "[email protected]"
