https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230619
--- Comment #5 from Kristof Provost <k...@freebsd.org> --- Apologies for taking this long to get back to this. I've had other priorities in the past few months. I'm not sure about the M_WAITOK in pfr_create_kentry(), because the initial allocation there (for the pfr_kentry) is M_NOWAIT. It'll have to be another M_NOWAIT allocation, with appropriate error handling. The same applies to pfr_create_ktable(). In 'case PFRW_GET_ASTATS' it might make sense to move that code into its own function, if only to avoid the line length issues. It's so broken up now that it's not very readable any more. Other than those minor points, I think this is ready to go in. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ freebsd-pf@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-pf To unsubscribe, send any mail to "freebsd-pf-unsubscr...@freebsd.org"
