On 4/13/07, Gerald Pfeifer <[EMAIL PROTECTED]> wrote:
On Fri, 13 Apr 2007, Rong-en Fan wrote:
> I think it's because lang/gcc41, gcc42's usage of USE_GNOME is incorrect.
> It should be
>
> WANT_GNOME= yes
>
> .include <bsd.port.pre.mk>
>
> USE_GNOME+=
>
> And our INDEX builder is i386, so we don't see this.
Thanks for the report and the diagnosis. I'm away from a machine where
I can do a reasonable FreeBSD test/commit.
Would the patch below address the issue? If so, anybody feel free to
commit to the lang/gcc41 and lang/gcc42 ports!
(Now, there is a huge problem with this: The idea behind the original
changes was to use OPTIONS for these ports. Alas OPTIONS are processed
in bsd.port.mk.pre so their WITH/WITHOUT settings are available only after
bsd.port.mk. If we have to define WANT_GNOME before bsd.port.mk.pre, the
result of OPTIONS is not available yet. Does this mean we cannot sensibly
use OPTIONS for optional dependencies like this?)
No, the patch won't work. According to
http://www.freebsd.org/gnome/docs/porting.html,
the right way is always define WANT_GNOME which won't pull
any gnome dependencies unless USE_GNOME is used.
I think after USE_PERL5_BUILD line, add
WANT_GNOME=yes
and use += for USE_GNOME after bsd.port.pre.mk
Regards,
Rong-En Fan
Gerald
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v
retrieving revision 1.318
diff -u -3 -p -r1.318 Makefile
--- Makefile 10 Apr 2007 05:24:27 -0000 1.318
+++ Makefile 13 Apr 2007 06:24:29 -0000
@@ -34,6 +34,9 @@ USE_BZIP2= yes
USE_GMAKE= yes
USE_ICONV= yes
USE_PERL5_BUILD=yes
+.if defined(WITH_JAVA_AWT)
+WANT_GNOME= yes
+.endif
PATCH_WRKSRC= ${SRCDIR}
CONFIGURE_SCRIPT= ../${SRCDIR:C/${WRKDIR}//}/configure
_______________________________________________
[EMAIL PROTECTED] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "[EMAIL PROTECTED]"
