On Thu, 2007-05-24 at 07:35 -0500, Stephen Montgomery-Smith wrote: > Pav Lucistnik wrote: > > Stephen Montgomery-Smith píše v st 23. 05. 2007 v 20:04 -0500: > > > >> I'm getting kind of uncomfortable with the patch. I looked some more > >> in > >> bsd.gnome.mk and it seems to me that the suggested patch is really > >> equivalent to the patch enclosed here. > >> > >> Why did the writer of bsd.gnome.mk have the rather complicated > >> construction which I am proposing to replace? > > > > I don't know, we'd have to ask Joe Marcus. Here is the revision in > > question: > > > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=1.22;r2=1.23 > > > > You're basically reverting that revision. Perhaps our make(1) wasn't > > smart enough those four years ago, I don't know. > > I'm not really reverting that revision. As it was prior to that > revision, I can see it not working under many circumstances. Namely, if > ${component} appears more than once in ${_USE_GNOME} - something that > will happen frequently - the test will not work. > > My revision seems the obvious way to do it to me, but I can see that if > someone was working with what Joe was working with, that one could be > lead to think up his revision. I know that I myself have missed the > obvious in many circumstance.
I believe this will work, but it's been so long since I did this work. I think the problem was that :M used to match "eel" when USE_GNOME contained "eel2". But that doesn't appear to be the case anymore. Joe -- PGP Key : http://www.marcuscom.com/pgp.asc
signature.asc
Description: This is a digitally signed message part
