FYI -- I found a bug (described below) in x11-wm/piewm; I removed the patch from the forwarded copy of the message I sent to Russ Nelson, and have attached it to this one for convenience -- just in case there's anyone else out there who still uses piewm. :-}
I have not created a FreeBSD PR for this, but I can, if that's desired. ----- Forwarded message from David Wolfskill <[EMAIL PROTECTED]> ----- Date: Sat, 22 Nov 2008 12:29:10 -0800 From: David Wolfskill <[EMAIL PROTECTED]> To: Russell Nelson <[EMAIL PROTECTED]> Subject: Re: Heads up: Another bug in piewm (and not in tvtwm) On Sat, Nov 22, 2008 at 11:52:39AM -0800, David Wolfskill wrote: > I don't have a patch yet, but the problem is in InstallWindowColormaps() > in events.c. > > If, while running piewm, one fires up Xnest, piewm gets a SIGSEGV > in InstallWindowColormaps, at events.c:2601 when the mouse travels > over the Xnest window: >... > I'm hoping to have a patch before the weekend is out, but I confess > that I'm not all that familiar with the code. > > .... OK; the attached patch appears to prevent the problem. The problem appears to be that the loop control variable, n, is being decremented only within a conditional block; when there are "cwin"s that fail to meet the condition, it isn't decremented, so the loop goes further than it's supposed to. (In the case in point, n started out as 2, and the 3rd iteration of the loop had a bit of a problem, as by thta point, maxcwin would be pointiing to cwins[-1]. Urrgh.) Peace, david -- David H. Wolfskill [EMAIL PROTECTED] Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key. ----- End forwarded message ----- Peace, david -- David H. Wolfskill [EMAIL PROTECTED] Depriving a girl or boy of an opportunity for education is evil. See http://www.catwhisker.org/~david/publickey.gpg for my public key.
--- events.c.orig 1998-01-07 22:11:39.000000000 -0800
+++ events.c 2008-11-22 12:13:35.000000000 -0800
@@ -2606,8 +2606,8 @@
XInstallColormap(dpy, cmap->c);
}
cmap->state |= CM_INSTALLED;
- n--;
}
+ n--;
}
}
pgpAGRzJmA0ak.pgp
Description: PGP signature
