On Sat, 23 May 2009 18:24:26 +0900 (JST) Maho NAKATA <cha...@mac.com> wrote:
> Hi David > > Many many thanks for your patch. I'll test it very soon. > > Just one comment > > I believe openoffice-2* can me marked as SAFE while openoffice-3* > > should not be marked at all (since it sometimes works..., very well > > for me :-). > you can mark as SAFE for all of our ports. For testing, right? > If it's broken, its OOo issue. Obviously. > We should identify if dependencies are missing. -devel ports can be > unsafe but 3, 3-RC 2, 2-RC must be safe. > > Please wait a few days to say ok. I'll give them a try during this weekend. > From: David Naylor <naylor.b.da...@gmail.com> > Subject: Re: MAKE_JOBS_UNSAFE (some more ports) > Date: Sat, 23 May 2009 11:01:56 +0200 [ .. ] > > Please see attached for the patch. The changes to bsd.port.mk: > > - MAKE_JOBS_NUMBER always defined > > - MAKE_JOBS_NUMBER forced to 1 if UNSAFE of DISABLE AFAIR there are ports that compile OK w/o MAKE_JOBS_SAFE but fail with MAKE_JOBS_NUMBER=1 > > - MAKE_JOBS_NUMBER defaults (but user defined) to number of cores This part looks OK, I wonder if there's any reason t ain't like this now; Pav? -.if defined(MAKE_JOBS_NUMBER) +MAKE_JOBS_NUMBER?= `${SYSCTL} -n kern.smp.cpus` _MAKE_JOBS= -j${MAKE_JOBS_NUMBER} -.else -_MAKE_JOBS= -j`${SYSCTL} -n kern.smp.cpus` -.endif I believe pav@ didn't put the ' && !defined(MAKE_JOBS_SAFE)' part intentionally until we get to test all our ports. -.if defined(FORCE_MAKE_JOBS) +.if defined(FORCE_MAKE_JOBS) && !defined(MAKE_JOBS_SAFE) BUILD_FAIL_MESSAGE+= "You have chosen to use multiple make jobs (parallelization) for all ports. This port was not tested for this setting. Please remove FORCE_MAKE_JOBS and retry the build before reporting the failure to the maintainer." > > I've then used MAKE_JOBS_NUMBER to set MAXPROCESSES, MAXMODULES and > > NUMOFPROCESSES for openoffice-* (not including 1.*). > > > > I believe openoffice-2* can me marked as SAFE while openoffice-3* > > should not be marked at all (since it sometimes works..., very well > > for me :-). > > > > This patch just makes openoffice-* behave like other ports in > > regards to parallel builds and the usual MAKE_JOBS variables now > > works as expected. Nice, thanks. -- IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> ite...@freebsd.org, PGP Key ID 057E9F8B493A297B
signature.asc
Description: PGP signature