Hey

Please test the new patch. @ Stefan thx for the PR.

http://people.freebsd.org/~miwi/psaa.diff

- Martin

On Feb 27, 2013, at 4:04 PM, Stefan Bethke <s...@lassitu.de> wrote:

> 
> Am 27.02.2013 um 09:01 schrieb Dimitry Andric <dimi...@andric.com>:
> 
>> On 2013-02-27 00:39, Stefan Bethke wrote:
>> ...
>>> openbsd-compat/vis.h is #ifdef'd HAVE_STRNVIS, so we check configure.  
>>> configure.log thinks we have a suitable strnvis:
>>> 
>>> configure:16566: checking for strnvis
>>> configure:16622: cc -o conftest -O2 -pipe -fno-strict-aliasing -fPIC -Wall 
>>> -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign 
>>> -fstack-protector-all   -fstack-protector-all conftest.c  -lutil -lpam >&5
>>> configure:16629: $? = 0
>>> configure:16651: result: yes
>>> 
>>> 
>>> Do we?
>> 
>> We have strnvis(), but it is not suitable.  We got strnvis() from
>> NetBSD, and its arguments are in a different order from OpenBSD's
>> version.  See the archive for earlier discussions (and crash reports :)
>> about this.
>> 
>> I recommend adding the line:
>> 
>> CONFIGURE_ENV=               ac_cv_func_strnvis=no
>> 
>> to the port Makefile, just as with security/openssh-portable.
> 
> Ah, neat, I didn't know you could do that in a Makefile.  I've just submitted 
> ports/176469 with a patch to configure, but this much nicer.
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=176469
> 
> 
> Stefan
> 
> -- 
> Stefan Bethke <s...@lassitu.de>   Fon +49 151 14070811
> 
> 
> 
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
> 

+-----------------oOO--(_)--OOo-------------------------+
With best Regards,
       Martin Wilke (miwi_(at)_FreeBSD.org)

Mess with the Best, Die like the Rest

_______________________________________________
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Reply via email to