Hello Ben, Thank you very much for your reply and your time!
We'll implement your notes into our ports :) -- Best regards, Piotr Robert Konopelko *MooseFS Technical Support Engineer* | moosefs.com[1] Nice work putting the ports together - its a good first effort! I have a few comments about the format of the ports and bug reports - sorry there are quite a few. I don't mean to be picky, but I wanted to minimise the back-and-forth for you to get these committed. 1. Updates to existing ports should be attached as patches to the current ports tree. The easiest way to do this if you got the ports tree from subversion (not portsnap) is using the svn diff command. Tick the "patch" option when attaching so we can see a nice pretty diff from within bugzilla. 2. New ports should be attached as a shar(1) file. Assuming the port is called oneko, cd to the directory above where the oneko directory is located, and then type: shar `find oneko` > oneko.shar 3. It's nice for ports for share parts of their configuration, but I don't think it should be called "bsd.port.moosefs.mk[2]" (this implies it is part of the port build scripts). A good example of what you could do is devel/libtool. It has a Makefile which includes Makefile.common. The devel/libltdl port also includes "${.CURDIR}/../libtool/Makefile.common". 4. @dirrm is now deprecated in pkg-plist. Suggest it is probably easier to build this with "make install && make makeplist > pkg-plist". Note that you should check the plist looks correct, and also delete the top warning line from the generated file. 5. The pkg-descr file should be updated to include a better description of the package, and link to the website. 6. Before submitting a port, check that it passes the normal checks by installing the ports- mgmt/portlint program, and running "portlint -AC" in the port directory. 7. If you have access to a poudriere installation, you should submit the "poudriere testport" logs showing that this port will build successfully. Myself or other ports contributors/committers can help with this if you do not have access to a poudriere installation, but please make sure you have at least tested the build on FreeBSD with a "make install". Much of this is covered in the porter's handbook. It's a good read if you haven't already seen it. You can find it here: https://www.freebsd.org/doc/en/books/porters-handbook/book.html[3] Note that if you re-submit patches to each bug report, be sure to tick the option that it obsolete's the previous patch. Good luck! :) Regards, Ben On Mon, Apr 13, 2015 at 7:05 PM Piotr Robert Konopelko <piotr.konope...@moosefs.com[4]> wrote: Thank you very much for this information. I posted requests to the FreeBSD bugzilla: https://bugs.freebsd.org/bugzilla/buglist.cgi?quicksearch=moosefs&list_id=56910[5] -- Best regards, Piotr Robert Konopelko *MooseFS Technical Support Engineer* | moosefs.com[1] Those ports currently have their maintainer fields set to "po...@freebsd.org[6]", meaning there is no maintainer. When you submit the bug report and attach your patch to update the port, simply ensure the maintainer email address is updated to your own. You will then be volunteering as the maintainer for those ports. Regards,Ben On Thu, 9 Apr 2015 at 9:12 pm Fernando Apesteguía <fernando.apesteg...@gmail.com[7]> wrote: El 09/04/2015 15:00, "Piotr Robert Konopelko" <piotr.konope...@moosefs.com[4]>escribió:>> Dear FreeBSD Ports team,>> On FreeBSD Ports site only ports for MooseFS 1.6.27-5 are available:> https://www.freebsd.org/cgi/ports.cgi?query=moosefs&stype=all[1][8] https://bugs.freebsd.org/bugzilla/[9] moosefs.com[1][2]>>> --------> [1] https://www.freebsd.org/cgi/ports.cgi?query=moosefs&stype=all[10] http://moosefs.com[1] freebsd-ports@freebsd.org[11] mailing list> http://lists.freebsd.org/mailman/listinfo/freebsd-ports[12] freebsd-ports- unsubscr...@freebsd.org[13]"_______________________________________________ freebsd-ports@freebsd.org[11] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports[12] freebsd-ports-unsubscr...@freebsd.org[13]" _______________________________________________ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"