On 21 Mar, Mathieu Arnold wrote: > +--On 21 mars 2016 11:18:26 -0700 Don Lewis <[email protected]> wrote: > | gnome-post-install does several different things. I haven't looked to > | see if all of them should be moved. Unfortunately I'm not sure that an > | exp-run would pick up some of the more subtle breakage. > > Then, we just extract the INSTALL_ICONS bits into a gnome-install-icons > target, and run it later, much later. The gnome-post-install target could > benefit from being split up. It was not so before because USES=gnome is > quite new, and adding stuff to the target ordering system was a pain. Now, > it could be splitted in gnome-gconf-schemas, gnome-glib-schemas, > gnome-installs-omf, and gnome-install-icons. It was on my roadmap when I > rewrote the target ordering system to use numbers, but I decided against > changing too many things at once.
That sounds fine to me. I didn't closely look at the rest of gnome-post-install since I was concentrating on the problem at hand. I'd also like a target explicity for generating a dynamic plist that runs after post-install. Doing it in post-install works most of the time unless you start using post-install option helpers to install additional files. > | One of my concerns is that if we start using TARGET_ORDER_OVERRIDE all > | over the place, that will make maintaining the framework a lot more > | difficult. > > There's a difference between all over the place and in a dozen ports :-) > (it only makes it about 0.05% of the time, if I get my math right) Well, here are a bunch more ... these contain both INSTALLS_ICONS and "autoplist", which I'm assuming comes from USES_GNOME=autoplist audio/puddletag/Makefile deskutils/gtg/Makefile deskutils/rednotebook/Makefile deskutils/syncthing-gtk/Makefile deskutils/vboxgtk/Makefile deskutils/virt-manager/Makefile deskutils/zim/Makefile devel/bzr-gtk/Makefile devel/gaphor/Makefile devel/qbzr/Makefile games/pyspacewar/Makefile multimedia/tovid/Makefile net-im/turpial/Makefile net-p2p/deluge/Makefile print/frescobaldi/Makefile www/linkchecker/Makefile x11/hotwire-shell/Makefile _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "[email protected]"
