Sergey, Romain Tartière (romain@) has just commented at https://reviews.freebsd.org/D13889:
"Great, this has annoyed me for a while, I fixed this upstream but this has not been released yet. Patching will therefore become useless in the future, but for now, thanks for fixing this!" Given the port will need to be redone when this new feature is released, I would like to proceed, with your approval, with the two slave ports as an interim measure. This will all be redundant once ruby FLAVORs are in. Thank you. -- Dan Langille - BSDCan / PGCon d...@langille.org > On Jan 12, 2018, at 8:11 PM, Sergey A. Osokin <o...@freebsd.org> wrote: > > Hi Dan, > > my suggestion in this case is to try to play with next options > in www/rubygem-passenger: > > OPTIONS_SINGLE= SERVER > OPTIONS_SINGLE_SERVER= APACHE22 NGINX > > Again, I believe it's possible to modify www/rubygem-passenger to > have ability to install necessary files to support one of them > (apache or nginx) or even both technologies. > > -- > Sergey A. Osokin > > On Fri, Jan 12, 2018 at 08:02:08PM -0500, Dan Langille wrote: >> Hello Sergey, >> >> The proposed solution is a short term solution which goes away when FLAVORS >> are done for ruby. This is not soon. >> >> We (feld@ & I) choose this solution as it has very little affect on the >> existing port. >> >> The need arose today & we hope to proceed quickly with whatever can be done. >> >> How do you suggest we proceed with the work? >> >> Thank you >> >> -- >> Dan Langille >> http://langille.org/ >> >> >>> On Jan 12, 2018, at 7:33 PM, Sergey A. Osokin <o...@freebsd.org> wrote: >>> >>> Hi Dan, >>> >>> I don't see any reason to create two separate ports in this case and support >>> them then cause potentially it's possible to modify the existing port to get >>> the same result. >>> >>> -- >>> Sergey A. Osokin >>> >>>> On Fri, Jan 12, 2018 at 10:18:37AM -0500, Dan Langille wrote: >>>> Sergey, >>>> >>>> We have a need to use rubygem-passenger with both Nginx and with Apache >>>> (on different servers). >>>> >>>> I propose to create two new slave ports: >>>> >>>> * www/rubygem-passenger-nginx >>>> * www/rubygem-passenger-passenger >>>> >>>> To do this, I would like to make a one-line change to the master port: >>>> >>>> >>>> Index: Makefile >>>> =================================================================== >>>> --- Makefile (revision 458852) >>>> +++ Makefile (working copy) >>>> @@ -24,7 +24,7 @@ >>>> APACHE22_DESC= Build with apache22 support >>>> NGINX_DESC= Build with nginx support >>>> SYMLINK_DESC= Create passenger symlink >>>> -OPTIONS_DEFAULT= APACHE22 >>>> +OPTIONS_DEFAULT=? APACHE22 >>>> >>>> USE_RUBY= yes >>>> RAKE_BIN= ${LOCALBASE}/bin/rake >>>> >>>> This will allow the slave port to set OPTIONS_DEFAULT and build for the >>>> desired web server. >>>> >>>> If you agree, I am happen to make the commit / submit a patch for your >>>> approval. >>>> >>>> Thank you. >>>> >>>> -- >>>> Dan Langille - BSDCan / PGCon >>>> d...@langille.org >>>> >>>> >> _______________________________________________ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
