For example, on the misc/orange3 port:

> $ make stage-qa
> ====> Running Q/A tests (stage-qa)
> [yuri@yv /usr/ports/misc/orange3]$ file ./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so > ./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so: ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically linked, not stripped


This is because the stage-qa check only looks at .debug sections, and file(1) looks at more sections.

My proposed partial fix was rejected: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230371 on the grounds that it goes against some other commit. So stage-qa doesn't check what it is supposed to check, and this is somehow ok.


Should this stage-qa check be changed to just run file(1) and check if the output contains "not stripped" in it? What would be the downside of this? I also don't understand what is the downside of the rejected patch in bug#230371 that expands the list of sections.


Yuri


_______________________________________________
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Reply via email to