Hi Marco,

just a few comments about your port stub.

Am 14.09.18 um 17:31 schrieb Marco Beishuizen:
> On Fri, 14 Sep 2018, the wise Lorenzo Salvadore via freebsd-ports wrote:
> 
>> Show us your makefile please.
> 
> The Makefile I have so far:
> 
> PORTNAME=        pgadmin4
> PORTVERSION=        3.3
> CATEGORIES=        databases
> MASTER_SITES=        PGSQL/pgadmin/pgadmin4/v${PORTVERSION}/source/

I would insert the next line, because it is common for Postgres ports
for years now, to hold the distfiles under distfiles/postgresql/

DIST_SUBDIR=    postgresql

I think, the following line is not necessary, the port fetches and build
fine without it:
> DISTNAME=        pgadmin4-${PORTVERSION}

> 
> MAINTAINER=        mb...@xs4all.nl
> COMMENT=        PostgreSQL Administration Tool
> 
> LICENSE=        PostgreSQL
> 
> BUILD_DEPENDS        sphinx-build:textproc/py-sphinx
> USES=            pgsql python qmake:outsource qt:5
> USE_QT=            core gui network widgets
> QMAKE_SOURCE_PATH=    ${WRKSRC}/runtime
> 
> .include <bsd.port.mk>
> 
>> When I created my first port, I remember I had some difficulty to
>> understand staging: imho it needs to be explained better in the
>> documentation. Are you aware of the variable ${STAGEDIR}? You probably
>> need to add to your makefile some lines similar to the followings:
>>
>> do-install:
>>   ${INSTALL_PROGRAM} ${WRKSRC}/??/pgAdmin4 ${STAGEDIR}${PREFIX}/bin
> 
> Quite possible that it's something like this. I'll dig into it.

Most of the needed stuff seems to be under ${WORKSRC}/runtime and
${WORKSRC}/web.

HTH a little bit.

Greetings,
Rainer

> 
> Thanks,
> 
> Marco
> 

_______________________________________________
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Reply via email to