https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196947
Kubilay Kocak <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-ports-bugs@FreeBSD. |[email protected] |org | Status|New |Open CC| |[email protected] Keywords| |feature, needs-patch, | |needs-qa, patch --- Comment #1 from Kubilay Kocak <[email protected]> --- Thanks for your submission Maxim. On initial review: - PORTNAME must match upstream name (python-pcre) - py- in PORTNAME should be removed, and PKGNAMEPREFIX=${PYTHON_PKGNAMEPREFIX} added instead - python is missing as a second entry for CATEGORIES - Add LICENSE_FILE is one exists in ${WRKSRC} - GH_PROJECT defaults to ${PORTNAME} which wont be needed after the above PORTNAME change - Sort USE_PYTHON values alphabetically - MAINTAINER is in the wrong location - WWW: entry is missing in pkg-descr (don't include a trailing slash) - There are a number of other Makefile entry order issues (portlint will tell you) Please also: - Attach portlint -AC output (after addressing any outstanding issues) - Attach successful poudriere build output. If you dont have poudriere, you can attach output of the following instead: make stage && make check-plist && make stage-qa && make package Bonus: - Include (attach) python unit test output - Create an issue upstream asking the author to upload the package to PyPi (under name python-pcre) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-python To unsubscribe, send any mail to "[email protected]"
