https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242320
Kubilay Kocak <ko...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|www/web2ldap: Update to |www/web2ldap: Update to
|1.5.45, Remove BROKEN |1.5.68, Remove BROKEN
--- Comment #4 from Kubilay Kocak <ko...@freebsd.org> ---
(In reply to daniel.engberg.lists from comment #3)
To be precise, a ports job is only to 'declare' what versions of Python a
package *supports*, not prescribe what version of Python the port should *use*.
Regarding:
-PORTVERSION= 1.3.16
+PORTVERSION= 1.5.18
...
-USES= cpe python:2.7
+USES= cpe python:3.6+
If 1.5.18 (now 1.5.68, see below) *only* supports 3.6+, then the change is
correct and acceptable. Upstream setup.py currently specifies:
python_requires='>=3.6.*',
Also, upstream is now at version 1.5.68. This issue needs an updated patch.
While we're here, other review items:
- The package ships tests, please add TEST_DEPENDS and a (do-)test target to
run them for QA.
- The package specifies console_scripts for command line scripts, so the port
must be made concurrent safe (USE_PYTHON=concurrent)
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"
