On Sun, May 10, 2009 at 03:00:26PM +0100, Mike Clarke wrote:
> 
> Each time gimp-app gets upgraded I lose the ability to open URI's 
> with "Open location" or by dragging images from firefox.
> 
> Apparently this is because I need to explicitly pass --without-gvfs to 
> configure [1] [2]. I was rather surprised that I needed to do this 
> since I have the gvfs port installed but it did the trick for me. What 
> I do is to edit the Makefile and add --without-gvfs to the 
> CONFIGURE_ARGS lines. The snag is that I invariably forget about this 
> by the next time the port gets upgraded and I have to sort the problem 
> out again. What could I add to /etc/make.conf to have this option added 
> to CONFIGURE_ARGS automatically?
> 
> [1] http://www.shallowsky.com/blog/gimp/index.html
> [2] http://www.gimp.org/release-notes/gimp-2.6.html

The gimp-app port Makefile should be hacked so that it adds --without-gvfs to
CONFIGURE_ARGS if the existing GVFS option is set to "no". You can try
the attached patch 'gimp-app.Makefile.diff'. If it works, you can submit
it with a PR. 

From the first link, I understand that it _could_ be that the
--without-gnomevfs currently in CONFIGURE_ARGS needs to be added to the
first part of the if-statement. If the first patch isn't sufficient,
restore the original Makefile and try the second patch
'gimp-app2.Makefile.diff'. 


Roland
-- 
R.F.Smith                                   http://www.xs4all.nl/~rsmith/
[plain text _non-HTML_ PGP/GnuPG encrypted/signed email much appreciated]
pgp: 1A2B 477F 9970 BA3C 2914  B7CE 1277 EFB0 C321 A725 (KeyID: C321A725)
--- Makefile.orig	2009-05-10 17:53:17.000000000 +0200
+++ Makefile	2009-05-10 17:56:17.000000000 +0200
@@ -132,12 +132,14 @@
 CONFIGURE_ARGS+=	--without-dbus
 .endif
 
-.if defined(WITH_GVFS) || ${HAVE_GNOME:Mgvfs}!=""
+.if defined(WITH_GVFS)
 LIB_DEPENDS+=	gnome-keyring.0:${PORTSDIR}/security/gnome-keyring
 USE_GNOME+=	gvfs
 .  if ${HAVE_GNOME:Mlibgnomeui}!=""
 USE_GNOME+=	libgnomeui
 .  endif
+.else
+CONFIGURE_ARGS+=        --without-gvfs
 .endif
 
 .endif
--- Makefile.orig	2009-05-10 17:53:17.000000000 +0200
+++ Makefile	2009-05-10 18:00:20.000000000 +0200
@@ -55,8 +55,7 @@
 		--disable-python \
 		--with-desktop-dir=${PREFIX}/share \
 		--docdir=${PREFIX}/share/doc/gimp \
-		--enable-default-binary \
-		--without-gnomevfs
+		--enable-default-binary
 CONFIGURE_ENV=	CPPFLAGS="-I${LOCALBASE}/include" \
 		LDFLAGS="-L${LOCALBASE}/lib" \
 		GIMP_THREAD_LIBS=${PTHREAD_LIBS}
@@ -132,12 +131,15 @@
 CONFIGURE_ARGS+=	--without-dbus
 .endif
 
-.if defined(WITH_GVFS) || ${HAVE_GNOME:Mgvfs}!=""
+.if defined(WITH_GVFS)
+CONFIGURE_ARGS+=	--without-gnomevfs
 LIB_DEPENDS+=	gnome-keyring.0:${PORTSDIR}/security/gnome-keyring
 USE_GNOME+=	gvfs
 .  if ${HAVE_GNOME:Mlibgnomeui}!=""
 USE_GNOME+=	libgnomeui
 .  endif
+.else
+CONFIGURE_ARGS+=        --without-gvfs --with-gnomevfs
 .endif
 
 .endif

Attachment: pgp0K8oGPxana.pgp
Description: PGP signature

Reply via email to