On Fri, Feb 22, 2013 at 12:00:43AM +0200, Mikolaj Golub wrote: > It looks currently logs are only way to detect errors from hastd side. > Here is a patch that adds local i/o error statistics, accessable avia > hastctl: > > http://people.freebsd.org/~trociny/hast.stat_error.1.patch > > hastctl output: > > role: secondary > provname: test > localpath: /dev/md102 > extentsize: 2097152 (2.0MB) > keepdirty: 0 > remoteaddr: kopusha:7771 > replication: memsync > status: complete > dirty: 0 (0B) > statistics: > reads: 0 > writes: 366 > deletes: 0 > flushes: 0 > activemap updates: 0 > local i/o errors: 269 > > Pawel, what do you think about this patch?
I'm fine with the patchi except for missing breaks in switch added to
hastd/primary.c.
I'm also wondering... You count all those errors separately just to
print them as one number. If we do that already let's print them
separately, eg.
local i/o errors: read(0), write(3), delete(5), flush(9)
BTW. Why not to count activemap update errors as write and flush errors?
--
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://tupytaj.pl
pgpX_5TbRWObv.pgp
Description: PGP signature
