Looking forward to next week. Thanks again Devin. Nice work and well appreciated.
-- Jason Hellenthal Voice: 95.30.17.6/616 JJH48-ARIN > On Apr 7, 2014, at 18:45, <[email protected]> wrote: > > > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] >> Sent: Monday, March 31, 2014 12:05 PM >> To: 'Hiroki Sato'; [email protected] >> Cc: [email protected]; [email protected]; [email protected] >> Subject: RE: network.subr _aliasN handling >> >>> -----Original Message----- >>> From: Hiroki Sato [mailto:[email protected]] >>> Sent: Sunday, March 30, 2014 8:18 PM >>> To: [email protected] >>> Cc: [email protected]; [email protected]; [email protected] >>> Subject: Re: network.subr _aliasN handling >>> >>> <[email protected]> wrote >>> in <[email protected]>: >>> >>> dt> But that wouldn't have deterred me. 30+ days of silence is >>> dt> equivalent to acceptance -- just that I had noticed that the patch >>> dt> could be expanded to include mdconfig{,2} scripts. Was going to >>> dt> wait a full day to see if anyone balked at the expansion to >>> dt> include mdconfig{,2} and then move forward. >>> >>> I like the direction in general, but there are two more comments: > > Committed change: > http://svnweb.freebsd.org/changeset/base/264243 > >>> 1. sort(1) cannot be used [snip] >> >> Problem solved. > > Ended up beefing up the internal sort function (sort_lite()). > Gave it some more options and regression tested it against > several inputs and flags to always produce the same output > as sort(1). > >>> 2. Please put the normalization part into a function and use it in >>> get_if_var(), too. Adding another code for the same functionality >>> makes maintenance difficult. > > Aforementioned enhancements to address that included > in mentioned SVN r264243. > -- > Devin > > _____________ > The information contained in this message is proprietary and/or confidential. > If you are not the intended recipient, please: (i) delete the message and all > copies; (ii) do not disclose, distribute or use the message in any manner; > and (iii) notify the sender immediately. In addition, please be aware that > any message addressed to our domain is subject to archiving and review by > persons other than the intended recipient. Thank you.
smime.p7s
Description: S/MIME cryptographic signature
