> -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of > [email protected] > Sent: Monday, July 14, 2014 1:56 PM > To: 'Allan Jude'; [email protected]; [email protected] > Cc: 'Michael Dexter' > Subject: RE: Bug 191869 - tmux(1) refuses to start via service(8) > > > > > -----Original Message----- > > From: Allan Jude [mailto:[email protected]] > > Sent: Monday, July 14, 2014 1:50 PM > > To: [email protected]; [email protected] > > Cc: 'Michael Dexter' > > Subject: Re: Bug 191869 - tmux(1) refuses to start via service(8) > > > > On 2014-07-14 16:43, [email protected] wrote: > > > Hi -rc, > > > > > > I'd like to get a review on a proposed patch to service(8). > > > > > > I've filed BUG #191869: > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191869 > > > > > > Proposed commit/message below: > > > > > > Fix an issue with service(8) where utilities such as screen(1) and > > > tmux(1) would behave differently when utilizing rc-script was > > > invoked > > manually vs. > > > service(8). The issue being that these utilities require the TERM > > > environ variable to be set and service(8) was not passing it down. > > > > > > Reported by: Michael Dexter <[email protected]> > > > Reviewed by: <your name here> > > > MFC after: 3 days > > > X-MFC-to: stable/10, stable/9 > > > --This line, and those below, will be ignored-- > > > > > > M service/service.sh > > > > > > <see attached patch.txt> > > > > > > > This fix works for me. Solves the problem with my rc script that > > starts puppetdb in screen so I can reattach to the console in the future. > > > > I don't think it should cause any problem with the regular scripts as > > they startup, since TERM will be set to a reasonable default (cons25) > > > > Thanks Allan, > > If no objections by late tonight, I'll make the commit.
Pinging myself here that I forgot to include in the above proposed commit message "PR: ####". New proposed commit message: Fix an issue with service(8) where utilities such as screen(1) and tmux(1) would behave differently when utilizing rc-script was invoked manually vs. service(8). The issue being that these utilities require the TERM environ variable to be set and service(8) was not passing it down. Reported by: Michael Dexter <[email protected]> PR: bin/191869 Reviewed by: allanjude MFC after: 3 days X-MFC-to: stable/10, stable/9 --This line, and those below, will be ignored-- M service/service.sh -- Devin _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-rc To unsubscribe, send any mail to "[email protected]"
