Sorry for the delay, I was trying to avoid rebooting my server. I've setup a similar environment in VirtualBox to test it.
On 2010-Jan-27 12:52:29 +0100, Marius Strobl <[email protected]> wrote: >Ah, I forgot that using nfsm_aligned() causes nfs_realign() to >be a NOP on architectures without strict alignment requirements >for performance reasons. That's generally fine but unfortunately >that way you don't actually exercise the code which caused the >problem before (unfortunately I still don't manage to hit the >unaligned case myself). >Could you please test with #ifdef __NO_STRICT_ALIGNMENT replaced >with #if 0 in sys/nfs/nfs_common.h? The vfs.nfs.realign_count >counter should also increase then. I'm not sure what triggers the unaligned case either - I tried roughly "tar -cf - -C /mnt/usr src | tar -xf - -C /mnt/tmp" and that caused some unaligned accesses (but also completely wedged the VBox host). I also tried copying a pile of files off my NFS client (FreeBSD-8.x/i386) and that also triggered some unaligned accesses without any errors being reported. Currently, I have: vfs.nfs.realign_count: 12 vfs.nfs.realign_test: 188817 I'd say that your patch works. -- Peter Jeremy
pgpo9qRNnpyHO.pgp
Description: PGP signature
