Re: aesni(?) corrupts data on 8.2-BETA1

[Kostik Belousov]

On Sat, Dec 11, 2010 at 07:37:51PM -0500, Mike Tancsa wrote:
> On 12/11/2010 6:22 PM, Kostik Belousov wrote:
> > On Sat, Dec 11, 2010 at 06:08:08PM -0500, Mike Tancsa wrote:
> >> On 12/11/2010 11:01 AM, Kostik Belousov wrote:
> >>>
> >>> I have no access to AESNI hardware. For start, you may use
> >>> src/tools/tools/crypto/cryptotest
> >>> to somewhat verify the sanity of the driver.
> >>
> >> I doesnt happen every time, but one out of 5 or so 
> >>
> > First, which arch is it, amd64 or i386 ?
> > 
> > Also, please revert r216162 and do the same tests.
> 
> Hi,
>       Its AMD64, but i386 seems to be impacted too. I am not sure how to
> revert to a specific commit, but for now I csup'd with a date tag of
> 
> *date=2010.12.02.23.00.00
> 
> which is a day before
> http://lists.freebsd.org/pipermail/svn-src-stable-8/2010-December/004338.html
> 
> 
> And that seems to fix it!
> 
> I  have been running
> cryptotest -c -z -t 10
> in a loop for the past 10min and not one error.

Please try this patch on the latest HEAD or RELENG_8.

diff --git a/sys/amd64/amd64/fpu.c b/sys/amd64/amd64/fpu.c
index 482b5da..1b493b4 100644
--- a/sys/amd64/amd64/fpu.c
+++ b/sys/amd64/amd64/fpu.c
@@ -426,7 +426,9 @@ fpudna(void)
                fxrstor(&fpu_initialstate);
                if (pcb->pcb_initial_fpucw != __INITIAL_FPUCW__)
                        fldcw(pcb->pcb_initial_fpucw);
-               fpuuserinited(curthread);
+               pcb->pcb_flags |= PCB_FPUINITDONE;
+               if (PCB_USER_FPU(pcb))
+                       pcb->pcb_flags |= PCB_USERFPUINITDONE;
        } else
                fxrstor(pcb->pcb_save);
        critical_exit();
diff --git a/sys/i386/isa/npx.c b/sys/i386/isa/npx.c
index 9ec5d25..f314e44 100644
--- a/sys/i386/isa/npx.c
+++ b/sys/i386/isa/npx.c
@@ -684,7 +684,9 @@ npxdna(void)
                fpurstor(&npx_initialstate);
                if (pcb->pcb_initial_npxcw != __INITIAL_NPXCW__)
                        fldcw(pcb->pcb_initial_npxcw);
-               npxuserinited(curthread);
+               pcb->pcb_flags |= PCB_NPXINITDONE;
+               if (PCB_USER_FPU(pcb))
+                       pcb->pcb_flags |= PCB_NPXUSERINITDONE;
        } else {
                /*
                 * The following fpurstor() may cause an IRQ13 when the

pgpA0gqcjE6TG.pgp
Description: PGP signature