On 08/29/2015 15:41, Konstantin Belousov wrote:
On Sat, Aug 29, 2015 at 03:01:38PM +0200, Jilles Tjoelker wrote:
Looks good to me, except that I think a vforked child (in system() and
posix_spawn*()) should use the system calls and not libthr's wrappers.
This reduces the probability of weird things happening between vfork and
exec, and also avoids an unexpected error when
posix_spawnattr_setsigdefault()'s mask contains SIGTHR.
Thank you for the review, I agree with the note about vfork. Updated
patch is below. Also, I removed the PIC_PROLOGUE from the i386 setjmp,
it has no use after the plt calls are removed.
I verified the patch. The getumask part of lib/libc/gen/setmode.c part was
rejected on stable/10 (probably due to other changes in ^/head.)
Cheers
Michiel
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "[email protected]"
