Shifted ata raid drives display at boot.

[Artur Pydo]

Hi,

I can see for a long time now shifted ata raid drives display at boot :

{...]
ar0: 38172MB <ATA RAID1 array> [4866/255/63] status: READY subdisks:
 0 READY ad4: 38172MB <MAXTOR 6L040J2> [77557/16/63] at ...
          1 READY ad6: 38172MB <MAXTOR 6L040J2> [77557/16/63] at ...
         acd0: CD-RW <LITE-ON LTR-32123S> at ata0-master UDMA33
[...]
I expected :

{...]
ar0: 38172MB <ATA RAID1 array> [4866/255/63] status: READY subdisks:
 0 READY ad4: 38172MB <MAXTOR 6L040J2> [77557/16/63] at ...
 1 READY ad6: 38172MB <MAXTOR 6L040J2> [77557/16/63] at ...
acd0: CD-RW <LITE-ON LTR-32123S> at ata0-master UDMA33
[...]
While looking through the sys/dev/ata/ata-raid.c file i found :

219     for (disk = 0; disk < rdp->total_disks; disk++) {
220         if (rdp->disks[disk].flags & AR_DF_PRESENT) {
221             if (rdp->disks[disk].flags & AR_DF_ONLINE)
222                 printf(" %d READY ", disk);
223             else if (rdp->disks[disk].flags & AR_DF_SPARE)
224                 printf(" %d SPARE ", disk);
225             else
226                 printf(" %d FREE  ", disk);
227             ad_print(AD_SOFTC(rdp->disks[disk]));
228             printf("         ");
229             ata_enclosure_print(AD_SOFTC(rdp->disks[disk])->device);
It seems that line 228 shifts the display of ata_enclosure information
if it exists, but if it does not it shifts the display of the next
displayed line.
Probably, line 228 should be moved to ata_enclosure_print function
instead.
--

Best regards,

Artur Pydo.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-stable" in the body of the message