When trying to build the 11.0-CURRENT clang 3.5 on powerpc64 I ran into a
violation of C++ accessibility rules (for private) that stopped the compile.
contrib/llvm/include/llvm/ADT/IntrusiveRefCntPtr.h has...
template <typename T>
class IntrusiveRefCntPtr {
T* Obj;
public:
...
template <class X>
IntrusiveRefCntPtr(IntrusiveRefCntPtr<X>&& S) : Obj(S.get()) {
S.Obj = 0;
}
...
}
To first illustrate a (partial) but-simpler-to-follow example use that would
show the problem:
using Ta = ...;
using Tb = ...;
// Note that private members of IntrusiveRefCntPtr<Ta>
// are not (should not be) accessible to
// IntrusiveRefCntPtr<Tb> methods (and vice-versa).
IntrusiveRefCntPtr<Ta> a{}
IntrusiveRefCntPtr<Tb> b{a};
// We then would have a usage where an example of:
IntrusiveRefCntPtr<Tb>::IntrusiveRefCntPtr
is then trying to access an example of
IntrusiveRefCntPtr<Ta>'s Obj private member.
It would take a friend relationship to be established to allow the cross-type
access to Obj.
The code in contrib/llvm/tools/clang/lib/Frontend/ChainedIncludesSource.cpp has
such a use and so makes an instance of the violation of the language rules in
the actual code.
The function clang::createChainedIncludesSourceIt uses classes...
class ChainedIncludesSource : public ExternalSemaSource
where...
class ExternalSemaSource : public ExternalASTSource
where...
class ExternalASTSource : public RefCountedBase<ExternalASTSource>
where...
template <class Derived> class RefCountedBase;
and it uses both of the following types...
IntrusiveRefCntPtr<ExternalSemaSource>
and...
IntrusiveRefCntPtr<ChainedIncludesSource>
In fact IntrusiveRefCntPtr<ChainedIncludesSource> is the return-expresison type
for the following routine that has return type
IntrusiveRefCntPtr<ExternalSemaSource>...
IntrusiveRefCntPtr<ExternalSemaSource> clang::createChainedIncludesSource(
CompilerInstance &CI, IntrusiveRefCntPtr<ExternalSemaSource> &Reader) {
...
IntrusiveRefCntPtr<ChainedIncludesSource> source(new ChainedIncludesSource());
...
return source;
}
===
Mark Millard
markmi at dsl-only.net
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "[email protected]"
