Quoting grem <[EMAIL PROTECTED]> (from Wed, 28 Mar 2007 04:52:53 +0200):

[analysis of the problem]

Any feedback is welcome, since I'm not an expert in how USB works/is implemented in FreeBSD.

Please submit this as a problem report. Quirks have to be registered in GNATS before we can commit them so that we are able to reevaluate them if the need arises.

@@ -1665,6 +1673,8 @@
                                USETDW(sc->csw.dCSWSignature, CSWSIGNATURE);
                }

+               if (sc->quirks & IGNORE_RESIDUE)
+                 USETDW(sc->csw.dCSWDataResidue, 0);
                int Residue;
                Residue = UGETDW(sc->csw.dCSWDataResidue);
                if (Residue == 0 &&

Wrong indent for the USETDW line. I don't know much about the USB code. If the residue is not used somewhere else, wouldn't it be better to do "if quirk set the Residue variable to 0 else get it from the device" instead of setting it?

Bye,
Alexander.

--
BOFH excuse #71:

The file system is full of it

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to