https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225558
Rodney W. Grimes <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Rodney W. Grimes <[email protected]> --- First pass look at this patch leads to these comments: White space change at line 40, this change should not be made -n option added out of alpha order at line 74, should be after -m, "ethernet adapter" is a little vague and missleading, this is actually "network adapter emulation type" I am not sure how much should be added to vmrun.sh, this was suppose to be a simple script for simple operations, if your getting complicated you should be invoking bhyve, not vmrun, the only other valid option for -n at this time is e1000, is it really worth adding a knob to vmrun.sh to switch between virtio-net and e1000? Or even if we consider the ne2000 out of tree code, that is a 3 way option. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization To unsubscribe, send any mail to "[email protected]"
