.. and yeah, that code is wrong. GCC doesn't complain; just change it to:

        if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&

to:

        if ((ahp->ah_enterprise_mode & AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&

Thanks, this is the first bug that I can file as having come from the
FreeBSD community. :)



Adrian


On 11 March 2013 17:41, Adrian Chadd <adr...@freebsd.org> wrote:
> Is this with clang?
>
>
>
>
> adrian
>
>
> On 11 March 2013 17:39, Joshua Isom <jri...@gmail.com> wrote:
>> Still no luck, and some errors look like I'm missing more.
>>
>>
>> /root/ATH/head/sys/modules/ath/../../dev/ath/ath_hal/ar9003/ar9300_misc.c:853:38:
>> error: use of logical '&&' with constant operand
>> [-Werror,-Wconstant-logical-operand]
>>         if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&
>>                                      ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> AR_ENT_OTP_MIN_PKT_SIZE_DISABLE is defined in ar9300reg.h and hardcoded.
>>
>> At least you figured out an easy way to genuine check to see if someone
>> tried your code.
>>
>>
>> On 3/11/2013 6:41 PM, Adrian Chadd wrote:
>>>
>>> Ooh.. add the debug options to your kernel, sorry!
>>>
>>> options ATH_DEBUG
>>> options AH_DEBUG
>>> options ATH_DIAGAPI
>>>
>>> I'm sorry, I've never tested it outside of a debug build before.
>>>
>>>
>>>
>>>
>>> Adrian
>>>
>>
_______________________________________________
freebsd-wireless@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-wireless
To unsubscribe, send any mail to "freebsd-wireless-unsubscr...@freebsd.org"

Reply via email to