Hi, The aligned will make sure that the structure gets padded properly to the size specified. Only on ARM/MIPS etc, structures get automatically aligned according to the element in the structure requiring the greatest alignment. I've test-compiled the USB WLAN drivers, and the aligned makes a difference. The problem is that the radiotap header skews some following elements, so that they are no longer aligned. The radiotap header itself is packed, and this is not a problem.
--HPS -----Original message----- > From:Warner Losh <[email protected] <mailto:[email protected]> > > Sent: Monday 29th July 2013 17:04 > To: Adrian Chadd <[email protected] <mailto:[email protected]> > > Cc: Hans Petter Selasky <[email protected] > <mailto:[email protected]> >; freebsd-arm > <[email protected] <mailto:[email protected]> >; > [email protected] <mailto:[email protected]> > Subject: Re: My WLI-UC-GNM up crash > > Aren't structures already aligned to 4 bytes when placed inside other > structures (unless marked __packed)? > > Warner > > On Jul 28, 2013, at 11:50 AM, Adrian Chadd wrote: > > > As long as that results in the radiotap structures being 4 or 8 byte > > padded when it's embedded in the softc - then yes, indeed. > > > > Xiao, can you try? > > > > > > -adrian > > > > On 28 July 2013 03:35, Hans Petter Selasky <[email protected] > > <mailto:[email protected]> > wrote: > >> Hi, > >> > >> Can you try the attached patch? > >> > >> --HPS > > _______________________________________________ > > [email protected] <mailto:[email protected]> mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > > <http://lists.freebsd.org/mailman/listinfo/freebsd-arm> > > To unsubscribe, send any mail to "[email protected] > > <mailto:[email protected]> " > > _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-wireless To unsubscribe, send any mail to "[email protected]"
