On Thu, May 24, 2018 at 8:42 PM, Roger Pau Monné <roger....@citrix.com> wrote: > On Thu, May 24, 2018 at 08:38:30PM +0530, Pratyush Yadav wrote: >> Hi, >> >> On Thu, May 24, 2018 at 7:36 PM, Roger Pau Monné <roger....@citrix.com> >> wrote: >> > On Thu, May 24, 2018 at 05:53:02PM +0530, Pratyush Yadav wrote: >> >> Hi everyone, >> >> >> >> I was reading the Xen grant table code and I noticed that some code is >> >> wrapped in an #if 0. You can see it in sys/xen/gnttab.h:138. I have >> >> also attached the "commented out" part down below. >> >> >> >> Is it useful? Is it all right if I submit a patch that removes it? >> > >> > This are leftovers from when the code was imported from Linux AFAICT. >> > I guess the original committer thought that those functions would be >> > implemented, so the prototypes where left in place. >> > >> > If you give me a patch to remove them I'm happy to commit it. >> >> How should I send you the patch? Should I send it through >> reviews.freebsd.org, GitHub pull request or just paste the patch in >> the email? > > Let's use reviews.freebsd.org, so that you can get used to it.
In case you didn't get the notificaton: https://reviews.freebsd.org/D15553 -- Regards, Pratyush Yadav _______________________________________________ freebsd-xen@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xen To unsubscribe, send any mail to "freebsd-xen-unsubscr...@freebsd.org"
