Hi everyone,

I was looking at gnttab_end_foreign_access_ref() and I notice that
while gnttab_end_foreign_access_ref() ends the foreign access, it does
not free the grant reference.

gnttab_end_foreign_access() free the reference by calling put_free_entry(ref).

gnttab_end_foreign_access_references() also frees the grant entries.

Shouldn't gnttab_end_foreign_access_ref() also free the grant entry?
It is an inconsistency at best and a bug at worst.

Is it ok if I submit a patch that calls put_free_entry(ref) in
gnttab_end_foreign_access_ref()?

-- 
Regards,
Pratyush Yadav
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xen
To unsubscribe, send any mail to "[email protected]"

Reply via email to