https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217998

duchateau.oliv...@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |duchateau.oliv...@gmail.com

--- Comment #1 from duchateau.oliv...@gmail.com ---
Your patch is not in good shape:

1. It depends of Gtk3, so you must replace USES= xfce by USES= xfce:gtk3 (it
requires Gtk3 support into xfce4-panel, it's enabled by default). Moreover
sorting USES is better

2. USE_GNOME= intlhack is not necessary

3. Why to remove %%NLS%% keyword in pkg-plist?

4. PORTREVISION is not necessary

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-xfce@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"

Reply via email to