Olivier Duchateau <duchateau.oliv...@gmail.com> has reassigned Bugzilla
Automation <bugzi...@freebsd.org>'s request for maintainer-feedback to
Bug 222942: misc/xfce4-weather-plugin: Update to 0.8.10

--- Description ---
Created attachment 187091
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=187091&action=edit
Patch to update misc/xfce4-weather-plugin

- Update to 0.8.10
- Remove unneeded patch

Note: tested with xfce4-panel 4.13.1 (Gtk3 only) I noticed some icons
disappeared (since switch to Gtk3, icons in panel are loaded differently), so
in panel 4.12.x everythin should be fine.

Moreover in my 4.13 branch [1], I have patch, which fixes logical
GtkOrientation enum (previous releases are also affected):

weather.c:2035:31: warning: implicit conversion from enumeration type
'XfcePanelPluginMode' to different enumeration type 'GtkOrientation'
    data->panel_orientation = xfce_panel_plugin_get_mode(panel);
                            ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
weather.c:2038:34: warning: comparison of constant
'XFCE_PANEL_PLUGIN_MODE_DESKBAR' (2) with expression of type 'GtkOrientation'
is always false [-Wtautological-constant-out-of-range-compare]
        (data->panel_orientation == XFCE_PANEL_PLUGIN_MODE_DESKBAR &&
         ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

As my patch is not yet review by upstream, and follow the FreeBSD Xfce team's
policy i'm waiting in order to propose my patch in the official ports tree.

freebsd-xfce@freebsd.org mailing list
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"

Reply via email to