Author: sveinung
Date: Wed Sep 3 16:24:05 2014
New Revision: 26205
URL: http://svn.gna.org/viewcvs/freeciv?rev=26205&view=rev
Log:
Gtk clients: Don't store spy action information in static variables
Unlike the other clients the Gtk clients won't wait until the previous spy
action is complete, follow up questions and all, before the next spy action
dialog is shown.
They used to store information like actor and target in static variables.
Follow up questions would use those variables. The variables would be
overwritten when the next spy action selection dialog was opened. This would
cause orders from follow up questions to be issued to the wrong actor and
against the wrong target.
Changes:
* Use actor and target information sent by the server with the follow up
questions now that the API forwards it.
* Store actor and target information in the GUI widgets using gpointer so
the functions called by the GUI can get it from there.
See bug #21636
Modified:
branches/S2_5/client/gui-gtk-2.0/diplomat_dialog.c
branches/S2_5/client/gui-gtk-3.0/diplomat_dialog.c
[This mail would be too long, it was shortened to contain the URLs only.]
Modified: branches/S2_5/client/gui-gtk-2.0/diplomat_dialog.c
URL:
http://svn.gna.org/viewcvs/freeciv/branches/S2_5/client/gui-gtk-2.0/diplomat_dialog.c?rev=26205&r1=26204&r2=26205&view=diff
Modified: branches/S2_5/client/gui-gtk-3.0/diplomat_dialog.c
URL:
http://svn.gna.org/viewcvs/freeciv/branches/S2_5/client/gui-gtk-3.0/diplomat_dialog.c?rev=26205&r1=26204&r2=26205&view=diff
_______________________________________________
Freeciv-commits mailing list
Freeciv-commits@gna.org
https://mail.gna.org/listinfo/freeciv-commits
