Author: sveinung
Date: Wed Apr 29 14:50:42 2015
New Revision: 28943

ruledit: Upgrade all old ruleset format effects.

When loading a ruleset in an old format it sometimes is necessary to do
something with/based on old effects. This is done by iterating over all old
effects with iterate_effect_cache() and the effect_list_compat_cb() callback

effect_list_compat_cb() had a bug. It always returned FALSE. This made
iterate_effect_cache() stop iterating after processing the first effect.
Any effect after the first one would therefore not by processed.

Fix the bug by making it always return TRUE in stead.

See bug #23546


Modified: trunk/server/rscompat.c
--- trunk/server/rscompat.c     (original)
+++ trunk/server/rscompat.c     Wed Apr 29 14:50:42 2015
@@ -184,7 +184,8 @@
     contacts->type = EFT_HAVE_CONTACTS;
-  return FALSE;
+  /* Go to the next effect. */
+  return TRUE;

Freeciv-commits mailing list

Reply via email to