Author: sveinung
Date: Mon Jul 13 15:54:48 2015
New Revision: 29217

URL: http://svn.gna.org/viewcvs/freeciv?rev=29217&view=rev
Log:
Comment: Explain why a dying unit shouldn't be bounced.

Modified:
    branches/S2_5/server/citytools.c

Modified: branches/S2_5/server/citytools.c
URL: 
http://svn.gna.org/viewcvs/freeciv/branches/S2_5/server/citytools.c?rev=29217&r1=29216&r2=29217&view=diff
==============================================================================
--- branches/S2_5/server/citytools.c    (original)
+++ branches/S2_5/server/citytools.c    Mon Jul 13 15:54:48 2015
@@ -684,6 +684,13 @@
       if (vunit->server.dying) {
         /* Don't transfer or bounce a dying unit. It will soon be gone
          * anyway.
+         *
+         * Bouncing a dying unit isn't a good idea.
+         * Remaining death handling may do things meant for its current
+         * location to the new location. (Example: Stack death)
+         * bounce_unit() will wipe the unit if it can't be bounced. Wiping
+         * the dying unit isn't a good idea. The remaining death handling
+         * code will try to read from it.
          *
          * Transfering a dying GameLoss unit as part of the loot for
          * killing it caused gna bug #23676. */


_______________________________________________
Freeciv-commits mailing list
Freeciv-commits@gna.org
https://mail.gna.org/listinfo/freeciv-commits

Reply via email to