<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39374 >

I configured with --enable-auth and got many warnings:

auth.c: In function ‘authdb_check_password’:
auth.c:422: attention : pointer targets in passing argument 3 of 
‘create_md5sum’ differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of ‘strlen’ 
differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of ‘strlen’ 
differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of 
‘__builtin_strcmp’ differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of ‘strlen’ 
differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of 
‘__builtin_strcmp’ differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of 
‘__builtin_strcmp’ differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of 
‘__builtin_strcmp’ differ in signedness
auth.c:423: attention : pointer targets in passing argument 1 of ‘strncmp’ 
differ in signedness

I don't see why this string (checksum) is defined unsigned, strange.

--- 12954/server/auth.c 2007-05-18 17:13:19.000000000 +0200
+++ test/server/auth.c  2007-05-18 17:11:15.000000000 +0200
@@ -415,7 +415,7 @@
#ifdef HAVE_AUTH
   bool ok = FALSE;
   char buffer[512] = "";
-  unsigned char checksum[DIGEST_HEX_BYTES];
+  char checksum[DIGEST_HEX_BYTES];
   MYSQL *sock, mysql;

   /* do the password checking right here */

_________________________________________________________________
Ten :  Messenger en illimité sur votre mobile !  
http://mobile.live.fr/messenger/ten/



_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to