<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39575 >

at revision 13068, 13069 and 13070, ATTRIBUTE_CHUNK_SIZE had been changed.
But, ATTRIBUTE_CHUNK_SIZE is used to define packets.

PACKET_PLAYER_ATTRIBUTE_CHUNK=47; pre-send, sc,cs,handle-via-packet
  UINT32 offset, total_length, chunk_length;
  /* to keep memory management simple don't allocate dynamic memory */
  MEMORY data[ATTRIBUTE_CHUNK_SIZE:chunk_length];
end

This cause nowadays lot of server's crash in metaserver. The half of the
players have ATTRIBUTE_CHUNK_SIZE = 1400, the other ATTRIBUTE_CHUNK_SIZE
= 2*1024.

IT'S VERY DANGEROUS TO CHANGE PACKET DEFINITIONS WITHOUT REDEFINE
CAPABILITY STRING.

Please make something fast. Thank you.

_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to