<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39901 >

William Allen Simpson wrote:
> Is this a Fedora only kind of thing?
So, I did a bit of Googling, and there are a number of other reports about
Fedora and this new requirement....  As a long-time BSD contributor, one of
the things that annoys me about certain Linux practices is the failure to
follow the documentation (in this case, "may" really should be optional).

Never-the-less, I tested, and there is another bug on the same line.  The
server overwrites parts of the client generated log.  It needs O_APPEND.

There is also a comment that isn't implemented.  I added FIXME, until the
issue is better understood.

In fact, this whole logging section seems incompletely implemented.  Why is
the debug level for the server always set to 3, no matter what the level on
the client?

Anyway, since this actually has a bug, I'll commit immediately.  Thanks!

Committed S2_1 revision 14050.
Committed S2_2 revision 14051.
Committed trunk revision 14052.

Index: client/connectdlg_common.c
--- client/connectdlg_common.c  (revision 14049)
+++ client/connectdlg_common.c  (working copy)
@@ -250,9 +250,9 @@
-    /* include the port to avoid duplication */
+    /* FIXME: include the port to avoid duplication? */
     if (logfile) {
-      fd = open(logfile, O_WRONLY | O_CREAT);
+      fd = open(logfile, O_WRONLY | O_CREAT | O_APPEND, 0644);
       if (fd != 1) {
         dup2(fd, 1);
Freeciv-dev mailing list

Reply via email to