<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39980 >

What is the very first thing done in handle_login_request()?

   freelog(LOG_NORMAL, _("Connection request from %s from %s"),
           req->username, pconn->addr);

The test for is_valid_username() is way down in the code?!?!

NEVER TRUST NETWORK DATA!

This is only one of many such problems....

Of course, there's the grammar: from from?  Yet 29 translators never
noticed the problem.



_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to