<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39563 >

On 10/02/2008, William Allen Simpson  wrote:
>
> Here's my proposed patch to rid us of this troublesome beast....

 I'd rather keep the function. Even though 'better' choice is
currently determined simply by comparing want value, that's not
necessarily true in the future.
 Currently logic of setting the want value is ugly and in some cases
just broken (magic numbers, cap values prohibiting big want of one
kind to interfere with want value of other kind...) We should clean up
all that mess and put the logic to just one central point:
copy_if_better_choice().


 - ML



_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to